railscamp / railscamp-germany-2013

RailsCamp Germany 2013
11 stars 6 forks source link

Menu is responsive now #32

Closed endverbraucher closed 11 years ago

endverbraucher commented 11 years ago

This should work better this Time. Menu should react responsive now without breaking the layout.

Can somebody check and merge this, please?

raucao commented 11 years ago

screen shot 2013-06-15 at 11 17 51 am

I think it's not 100% there yet. The flame is too small, the margin underneath it too large, and the margin on top of the menu icon is unnecessary, or it should be both on top and bottom of it.

Want to improve it a bit more before merging?

Oh, and on large screens the whole menu now has a weird padding on the bottom, by the way.

endverbraucher commented 11 years ago

Yeah, you’re right, this is not where it should be. I’ll try to improve these things before merging. Thanks for testing!

endverbraucher commented 11 years ago

I worked on the problems you’ve pointed to, and did made some other improvements:

menu mobile

menu open variants

I replaced the background of the menu items with a thin border; the variant with the background looked a little bit curious to me in combination with the menu icon. But I’m not sure, if I’m wrong on this, I can change this back.

I tested this on smaller browser sizes and on my iPhone. So if this still looks somewhere crazy, tell me!

jhilden commented 11 years ago

Merged this. If there are still issues, we can fix them in the main branch