search

railsdog / spree-multi-domain

Multiple Spree stores on different domains - single unified backed for processing orders
http://railsdog.com
46 stars 233 forks source link

The use of Deface #9

Closed technomage closed 13 years ago

technomage commented 13 years ago

The use of Deface imposes several new runtime dependencies, and extra run-time overhead over the prior use of hooks. Further the dependency is not included in the gemspec causing bundler to believe it succeeded but the gem set to be incomplete, and thus fail to run. The lack of version labels further makes it difficult to obtain a version prior to Deface while this settles down. This change will also require major rewrite of an existing site further complicating the situation.

technomage commented 13 years ago

I found the branches on the spree user account for stable versions.

romul commented 13 years ago

Yup, this repo is outdated at all. And there is no problem to determine needed branch, b/c Versionfile exists in spree/spree-multi-domain Besides, you can use gem version: https://rubygems.org/gems/spree_multi_domain for stores based on stable releses of Spree.

winfred commented 13 years ago

except that the gem you mention uses deface....

which throws an error a la

$ rails g spree:site /usr/local/lib/ruby/gems/1.9.1/gems/spree_multi_domain-3.0.5/lib/spree_multi_domain_hooks.rb:1:in `<top (required)>': uninitialized constant Deface (NameError)

this is straight from gem 'spree-multi-domain'

how did deface get into a 'stable' gem for this extension?

romul commented 13 years ago

That's strange issue, but you still can use 0-60-stable branch or 3.0.4 version of gem. So, it's not big deal anyways.