Update style.css - Githubissues

railsgirls / guides.railsgirls.com

Rails Girls Guides

https://guides.railsgirls.com/

Other

6.48k stars 744 forks source link

Update style.css #556

Closed AmanSingh81757 closed 1 year ago

AmanSingh81757 commented 1 year ago

The go to top button had hover effect even when not active (i.e when we the page is at the top).
Fixed by adding the hover effect and cursor pointer effect only when the button is active.

Can't add screenshot as the cursor isn't visible in screenshots.

Improvement on PR #547

AmanSingh81757 commented 1 year ago

@tombruijn hello, could you please review this PR and merge if no conflicts are found.

tombruijn commented 1 year ago

I think we should hide the button better. Like display: none by default for the .go-to-top-arrow class, or some visibility: hidden property, which then gets changed on hover.

Otherwise it is still there, only less apparent it's there, and could still get in the way.

tombruijn commented 1 year ago

@AmanSingh81757 do you want try those two options? Either display: none or visibility: hidden.

AmanSingh81757 commented 1 year ago

@AmanSingh81757 do you want try those two options? Either display: none or visibility: hidden.

I changed the css a bit to use the display property to hide the button when inactive and display it when scrolled down

AmanSingh81757 commented 1 year ago

@tombruijn I did the recommended changes could you merge the PR now