railsinstaller / railsinstaller-nix

RailsInstaller for OSX/Linux
http://railsinstaller.org/
65 stars 12 forks source link

No rvm.sh nor sm.sh #21

Open jsmm opened 10 years ago

jsmm commented 10 years ago

After installing/uninstalling, I get the following when opening a new terminal shell:

on ttys000 -bash: /etc/profile.d/sm.sh: No such file or directory -bash: /etc/profile.d/rvm.sh: No such file or directory

Thanks for your support,

mpapis commented 10 years ago

they both should be at the end of /etc/profile - we will fix it with next release

BradleyRoss commented 10 years ago

When I ran RailsInstaller, it did put the required lines at the end of /etc/profile. However, I would like to make a few comments.

If you are going to have the script change /etc/profile, I feel that you should have the script add a comment to the file indicating when the change was made and why. (MacPorts does something like this.)

I would personally prefer that changes be made to the .profile file for the individual user account rather than the system files. I have a few reasons for this. Changes to the individual .profile files will be more understandable than changes to the system file. (at least more obvious) Changes to the system file are things that malware would frequently do, and you would want to avoid things that may give false positives for malware. With all the changes I make to my .profile file, I accidentally overwrote some of the changes carried out by the system file.

mpapis commented 10 years ago

@BradleyRoss so

1) adding comments - good point 2) .profile can not be used as long as we do not have movable rubies in installer and possibility to select installation of rvm and tools to $HOME - it is planned for next release and the user (in $HOME) installation should be default