railsjazz / rails_live_reload

Live Reload for your Rails app. The easiest way to increase your productivity.
https://www.railsjazz.com/
MIT License
318 stars 8 forks source link

config.enabled config not working #26

Open MichalRemis opened 1 year ago

MichalRemis commented 1 year ago

I am using multiple development environments, but I found that rails_live_reload doesn't work in environments named other than "development". I have set the config in initializer:

config.enabled = Rails.env.development? || Rails.env.development_pl? || Rails.env.development_cz?

But it doesn't work. It's probably because _initializers/rails_livereload.rb is evaluated after _rails_livereload/engine.rb is loaded, where there is condition checking this (if RailsLiveReload.enabled? && defined?(::Rails::Server)...), which therefore doesn't use the config from intializer.

Is there please a way to make live reload work in environments other than 'development'?

I am using rails (6.1.4.1) and rails_live_reload (0.3.4)

igorkasyanchuk commented 1 year ago

hmm, interesting case @MichalRemis can you try to contribute to the gem?

MichalRemis commented 1 year ago

@igorkasyanchuk sorry I am too busy atm.. Maybe I would just remove config.enabled option from docs, since it doesn't work

igorkasyanchuk commented 1 year ago

no, removing it from doc has no value

I would just suggest to wait when you will have time, us or someone else

this setting should be modified

https://github.com/railsjazz/rails_live_reload/blob/5b86eb7630b256cad46b7a8393ff67bf07c0a33e/lib/rails_live_reload/config.rb#L28

for now you can just fork and edit it by yousefl

igorkasyanchuk commented 1 year ago

and if someone want's to fix, a possible approach can be like this https://github.com/igorkasyanchuk/rails_performance/blob/master/lib/rails_performance.rb#L55-L56

MGPalmer commented 7 months ago

I suppose noone had time yet? I just stumbled over the config option not working, I tried to make it configurable in our project like this:

config.enabled = (Rails.env.development? and (ENV.fetch("DISABLE_LIVE_RELOAD", nil) != "true"))

and also found that the setting seems to have no effect..