search

railslove / cmxl

your friendly MT940 SWIFT file parser for bank statements
http://railslove.com
MIT License
46 stars 25 forks source link

Support for RC and RD in :61: funds_code #14

Closed HDGhost closed 6 years ago

HDGhost commented 6 years ago

In MT940 (example here: https://www.kontopruef.de/mt940s.shtml) you need to accept up to two letters in the :61: funds_code

In your code (cmxl/lib/cmxl/fields/transaction.rb) you check for one letter 'C' or 'D', but in case of Storno you get a 'RC' or 'RD' which would cause an error in your cmxl-lib.

Can you fix these issue pls?

Greetings Ghost

bumi commented 6 years ago

Hi Ghost, thanks for reporting this. As you noted cmxl currently only supports "C" and "D". Are you interested in contributing the requested feature? I'd be happy to support you.

HDGhost commented 6 years ago

Hi bumi, thx for the fast answer. I would like to resolve this issue with you, but unfortunately there is no time for doing this atm. I wrote from work where i have another big project, that needs to be done in a short time.

bumi commented 6 years ago

sure, we all know that and it is the same here... a lot of things to do. I will keep this issue open for whoever finds time first.