search

railslove / cmxl

your friendly MT940 SWIFT file parser for bank statements
http://railslove.com
MIT License
46 stars 25 forks source link

Fix deprecation warnings for Ruby 2.7 #44

Closed JoeSouthan closed 4 years ago

JoeSouthan commented 4 years ago

👋 Been getting some deprecation warnings while upgrading to Ruby 2.7:

cmxl/lib/cmxl.rb:39: warning: Using the last argument as keyword parameters is deprecated

This PR adds ruby 2.7 to semaphore and fixes the deprecation

bumi commented 4 years ago

@JoeSouthan thanks a lot!! ...yay ruby 2.7

@Uepsilon you recently did this semaphore thing. It seems PR tests are not enabled. can you please enable that? if tests are green we can merge this one.

JoeSouthan commented 4 years ago

Hi 👋, any update on this being merged?

bumi commented 4 years ago

@JoeSouthan sorry for the late reply. I've added travis again as a CI and I've cherry-picked your commit into #49

will do a new release this this week!

JoeSouthan commented 4 years ago

Excellent, thanks for your help!

JoeSouthan commented 4 years ago

@bumi Would you be able to cut a new release please? 🙏

bumi commented 4 years ago

@JoeSouthan @mustangore thanks again and sorry for the delay v1.5.0 is released :shipit:

mustangore commented 4 years ago

Great, thank you so much.