railslove / fontello_rails_converter

CLI gem for comfortably working with icon fonts (open, download, convert) from http://fontello.com for usage in Rails apps.
MIT License
73 stars 35 forks source link

Fontello demo failed #27

Closed ka8725 closed 9 years ago

ka8725 commented 9 years ago

2015-05-21 at 4 17

jhilden commented 9 years ago

I think I might have seen a similar result and it had to do with the character encoding (in the CSS i think).

But in any case we would need much more information to help and ideally a test app to reproduce this bug.

cimm commented 9 years ago

Same problem here, what was the character encoding problem and how do we fix it?

ka8725 commented 9 years ago

I think that the problem in incorrect path to the assets files.

jhilden commented 9 years ago

If you could at least provide some additional information about your setup (rails & ruby versions, asset paths, etc.) maybe we can diagnose this further, otherwise it's all just guesswork.

The ideal thing would be a minimal rails test app that reproduces the problem.

doppelreim commented 9 years ago

In this fontello-issue https://github.com/fontello/fontello/issues/382 some CSS was inlined into the original demo.html (see https://github.com/fontello/fontello/commit/1d9ba71ef30902005351dafa56d6da9038132cee). The URLs in the inlined @font-face are not converted for the asset-pipeline.

I suspect https://github.com/railslove/fontello_rails_converter/blob/master/lib/fontello_rails_converter/cli.rb#L128 would need to bee amended?

jpwhitaker commented 9 years ago

I had the same issue, was very confused until I tried using an icon myself rather than looking at the demo.

Icons work, demo is not working.

Rails: 4.1.6 Ruby: 2.2.0

jhilden commented 9 years ago

I merged @doppelreim's PR and released a new version 0.4.0. Let me know if it works for you and fixes your issues with the fontello demo.

doppelreim commented 9 years ago

Cool! The fontello-demo is now working for me.

jhilden commented 9 years ago

thanks for verifying the bugfix