Closed Sinetheta closed 8 years ago
Thanks a lot for the fix @Sinetheta. Could you maybe provide some testcoverage for the fix you did?
That's a tough one. Since not much has been abstracted here I would have to actually hit (or mock) the file system. Which is generally not such a good thing.
A test for copy_config_json
would basically be
copy_config_json
Meaning that the spec would do about 5 times as much work as the method, which is why I imagine that it was never tested in the first place.
I've added a spec that just uses a mock to verify the call. A bit tautological, but hey, it's a test :wink:
thanks a lot. it might be a only a mock spec, but it will prevent a regression of this particular bug.
We have an option for specifying a config file, but that option is only used when opening a session. Whenever a new build is downloaded we throw the config.json in the same tired old location.