search

railslove / fontello_rails_converter

CLI gem for comfortably working with icon fonts (open, download, convert) from http://fontello.com for usage in Rails apps.
MIT License
73 stars 35 forks source link

Added --webpack option to "convert". #45

Closed mperrando closed 7 years ago

jhilden commented 7 years ago

thanks for that PR as well. I haven't used Rails 5 + webpack yet, but it seems reasonable to me.

Could you be so kind to add an "Options" section to the README and explain what the --wepack is for? In addition, while you are at it, could you maybe even bump the version and update the CHANGELOG, so I can publish a new release?

jhilden commented 7 years ago

awesome :tada:

mperrando commented 7 years ago

Sorry, but I was still refining the README. My bad that I was pushing on the PR branch.

jhilden commented 7 years ago

ok, sorry for being so hasty. just let me know when you are done with your changes and we will figure it out

mperrando commented 7 years ago

I'm done with commit fdab7848b4e06478b6428039214d1d948f10ba11.

Sorry for the messy branch.

jhilden commented 7 years ago

I cherry-picked that commit to master. I think everything should be fine now, or?

The new release has also already been published.

Thank you so much for your contribution again.