search

railslove / fontello_rails_converter

CLI gem for comfortably working with icon fonts (open, download, convert) from http://fontello.com for usage in Rails apps.
MIT License
73 stars 35 forks source link

Use HTTPS:// #49

Closed Overload119 closed 3 years ago

Overload119 commented 3 years ago

This gem is currently broken because Fontello now uses https:// by default.

Running fontello open for example will fail with this exception.

---- open ----
Traceback (most recent call last):
    15: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/bin/ruby_executable_hooks:24:in `<main>'
    14: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/bin/ruby_executable_hooks:24:in `eval'
    13: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/bin/fontello:23:in `<main>'
    12: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/bin/fontello:23:in `load'
    11: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/fontello_rails_converter-0.4.6/bin/fontello:138:in `<top (required)>'
    10: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/fontello_rails_converter-0.4.6/lib/fontello_rails_converter/cli.rb:17:in `open'
     9: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/fontello_rails_converter-0.4.6/lib/fontello_rails_converter/fontello_api.rb:16:in `new_session_from_config'
     8: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient.rb:70:in `post'
     7: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/request.rb:63:in `execute'
     6: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/request.rb:163:in `execute'
     5: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/request.rb:727:in `transmit'
     4: from /Users/amirsharif/.rvm/rubies/ruby-2.7.1/lib/ruby/2.7.0/net/http.rb:933:in `start'
     3: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/request.rb:743:in `block in transmit'
     2: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/request.rb:836:in `process_result'
     1: from /Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/abstract_response.rb:123:in `return!'
/Users/amirsharif/.rvm/gems/ruby-2.7.1/gems/rest-client-2.1.0/lib/restclient/abstract_response.rb:249:in `exception_with_response': 301 Moved Permanently (RestClient::MovedPermanently)
salimhb commented 3 years ago

@Overload119 thanks for the PR 👍 Just fix the failing test to also use https and we can merge it.

salimhb commented 3 years ago

tests fixed in #50