railslove / kickerapp

https://www.kicker.cool
25 stars 13 forks source link

Perform slug validation before checking for uniqueness #118

Closed namxam closed 7 years ago

namxam commented 7 years ago

Performing the uniqueness check before slug is sanitised allows to users to create multiple leagues with the same slug. That’s reaaaallly bad!

stephanpavlovic commented 7 years ago

sounds like a reaaaally bad idea

yoyostile commented 7 years ago

Erm, guys. The build is failing: https://travis-ci.org/railslove/kickerapp/builds/182008854

Besides that: I think this is a great brainteaser for @DonSchado 's https://github.com/DonSchado/broken-app :)