search

railslove / rack-tracker

Tracking made easy: Don’t fool around with adding tracking and analytics partials to your app and concentrate on the things that matter.
https://www.railslove.com/open-source
MIT License
648 stars 121 forks source link

1.5.1 patch release with regex fix #112

Closed bumi closed 6 years ago

bumi commented 6 years ago

We must do a 1.5.1 bugfix release with this commit: (already included in 1.6.0) https://github.com/railslove/rack-tracker/commit/b3d11e65dfc4ff60d7909c449a0e336f4da2ffb5

DonSchado commented 6 years ago

I'm not sure if this is really necessary 🤔

What might be a possible reason to not be able to update to 1.6?

bumi commented 6 years ago

because semantic versioning. it is a rather important bug fix and project that specify ~>1.5.0 as a version should get that fix.

the patch version says it is a backwards-compatible bug fix. the minor version introduced new features that are backwards-compatible.

DonSchado commented 6 years ago

Alright then, do it! :)

bumi commented 6 years ago

thanks!

bumi commented 6 years ago

bump, @DonSchado can you still to do a 1.5.1 release?