search

railslove / rack-tracker

Tracking made easy: Don’t fool around with adding tracking and analytics partials to your app and concentrate on the things that matter.
https://www.railslove.com/open-source
MIT License
647 stars 121 forks source link

Uncaught ReferenceError Fix: wrap Drift account ID in quotes #140

Closed sassela closed 5 years ago

sassela commented 5 years ago

Fixes issue with https://github.com/railslove/rack-tracker/pull/139

Thank you in advance!

bumi commented 5 years ago

damn, guess I should have done a better review. thanks for the fix. can you maybe adjust a test for that?

sassela commented 5 years ago

Sure, is this sufficient? Screenshot shows the test case failing on master and passing on this branch with the change.

Happy to extend further if needed

Screenshot 2019-07-31 at 17 09 31

DonSchado commented 5 years ago

will prepare the release this evening

DonSchado commented 5 years ago

@sassela please check the new release 1.11.1 :)

bumi commented 5 years ago

thanks @DonSchado

1.11.1 is the best release! :shipit:

sassela commented 5 years ago

Thanks to you both! Much appreciated