search

railslove / rcvr-app

recover provides localities a privacy-compliant, safe, and easy way for their guests to check in. See https://www.recoverapp.de/ for more details.
https://recoverapp.de
GNU Affero General Public License v3.0
41 stars 6 forks source link

adds deploy script #322

Open stringparser opened 3 years ago

stringparser commented 3 years ago

Adding a deploy script.

Maybe we should include a promotion in Semaphore too or instead of this?

salimhb commented 3 years ago

automating this might be risky in case it overrides BUILD_VARIANT by mistake.

bitboxer commented 3 years ago

@salimhb if that is risky we might not want to do an automatically git push as part of this script?

salimhb commented 3 years ago

@salimhb if that is risky we might not want to do an automatically git push as part of this script?

Yes, especially that pushing will deploy automatically. Instead of this script, I suggest adding these instructions in the README with a note about the environment variables.

stringparser commented 3 years ago

@salimhb, @bitboxer Hm, not sure if I understand but builds are done in vercel right? Also I think if is this problematic we could use the branch to determine the build (no BUILD_VARIANT environment variable I mean).

salimhb commented 3 years ago

These branches are literally there only to set the BUILD_VARIANT (see the diff) If there's a way to handle this in Vercel, we wouldn't have needed these branches to start with ;)

stringparser commented 3 years ago

These branches are literally there only to set the BUILD_VARIANT (see the diff) If there's a way to handle this in Vercel, we wouldn't have needed these branches to start with ;)

Yes yes. I see that but I don't know if we need the environment variable. We can simply use git to get the branch name and do the build based on this.