railsware / bozon

🛠 Command line tool for building, testing and publishing modern Electron applications
MIT License
758 stars 52 forks source link

gulp isn't defined in ./lib/utils/bozon.js #21

Closed alerdenisov closed 8 years ago

alerdenisov commented 8 years ago

Missing requirement of gulp module in ./lib/utils/bozon.js

alchaplinsky commented 8 years ago

Is it present in ./node_modules in your project directory?

alerdenisov commented 8 years ago

I mean you're using gulp variable without define it.. https://github.com/railsware/bozon/blob/master/lib/utils/bozon.js#L28

klevinlaughs commented 8 years ago

The requireLocal function returns a required instance of gulp. The function is defined it on line 37 of that file. Then he proceeds to use that instance.

eriedl commented 8 years ago

that is so not correct. while the apply function expects a "this argument", it cannot be inferred from the context it's called on. apply applies to functions not objects. Lines 27 and 34 would have to look something like this: return this.requireLocal('gulp').task.apply(this.requireLocal('gulp'), Array.prototype.slice.call(arguments, 1)) OR var gulp = this.requireLocal('gulp') return gulp.task.apply(gulp, Array.prototype.slice.call(arguments, 1))

alchaplinsky commented 8 years ago

Use version v0.5.5