railsware / sht_rails

Shared handlebars templates for Rails 3
http://blog.railsware.com/2012/05/21/shared-handlebars-templates-for-rails-3/
MIT License
76 stars 21 forks source link

Issue after pull rails master branch #14

Closed woto closed 11 years ago

woto commented 11 years ago

Hi, todaye i pulled rails master branch and found, that can't start application with sht_rails.

/home/woto/rails/yaponama_2012/vendor/cache/sht_rails-bd7fd373b6f0/lib/sht_rails/config.rb:22:in `template_base_path': undefined method `join' for nil:NilClass (NoMethodError)
    from /home/woto/rails/yaponama_2012/vendor/cache/sht_rails-bd7fd373b6f0/lib/sht_rails/engine.rb:4:in `block in <class:Engine>'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/activesupport/lib/active_support/lazy_load_hooks.rb:38:in `call'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/activesupport/lib/active_support/lazy_load_hooks.rb:38:in `execute_hook'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/activesupport/lib/active_support/lazy_load_hooks.rb:47:in `block in run_load_hooks'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/activesupport/lib/active_support/lazy_load_hooks.rb:46:in `each'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/activesupport/lib/active_support/lazy_load_hooks.rb:46:in `run_load_hooks'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/application.rb:118:in `initialize'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/railtie.rb:171:in `new'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/railtie.rb:171:in `instance'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/application.rb:88:in `inherited'
    from /home/woto/rails/yaponama_2012/config/application.rb:11:in `<module:Yaponama2012>'
    from /home/woto/rails/yaponama_2012/config/application.rb:10:in `<top (required)>'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/commands/commands_tasks.rb:75:in `require'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/commands/commands_tasks.rb:75:in `block in server'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/commands/commands_tasks.rb:72:in `tap'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/commands/commands_tasks.rb:72:in `server'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/commands/commands_tasks.rb:40:in `run_command!'
    from /home/woto/rails/yaponama_2012/vendor/cache/rails/railties/lib/rails/commands.rb:17:in `<top (required)>'
    from bin/rails:4:in `require'
    from bin/rails:4:in `<main>'

The problem with Rails.root it doesn't initialized in config.before_configuration, after changing to config.before_initialize it starts to work. But i'm not sure wich bug is it rails or sht_rails. What do think?

le0pard commented 11 years ago

Hello. As I understand this is rails 4. If yes, I will check it today...

woto commented 11 years ago

Ой, совсем забыл, что общаюсь с русскоговорящим разработчиком :)) Да. Проблема с Rails 4. Знаешь, я откатился назад до 4-0-stable, наверно все таки рано говорить, что баг не в Rails. Но... имей в виду. Ну и я, если вдруг что, вернусь в этот тикет.