search

railsware / upterm

A terminal emulator for the 21st century.
MIT License
19.24k stars 616 forks source link

The command line has unwanted ligatures in it #615

Closed bananu7 closed 8 years ago

bananu7 commented 8 years ago

Here's how it looks in action:

screen shot 2016-07-17 at 13 04 09

I didn't gather debug logs because I don't think they are necessary.

vlad-shatskyi commented 8 years ago

Hi, @bananu7. The "unwanted" part is questionable. I added them to show the programming ligatures supported by some fonts, e.g. https://github.com/tonsky/FiraCode. But I'm not saying we absolutely need them enabled, if people vote against, we'll remove them. One thing I'm certain about is that there will be no preference to optionally enable them.

Please vote. Thumb up - support ligatures, thumb down - don't support.

bananu7 commented 8 years ago

@shockone I think the ligature control options have some nice tweaking capabilities, allowing ligatures such as fi or ffi to be disabled, while still retaining the ones supported by e.g. FiraCode. I was unable to make such a change because of the type definition regarding WebkitFontFeatureSettings (I don't really understand why, as I have rather limited experience with React/Electron). I can try to fiddle around that and see whether it could be improved somehow.

All in all, though, for the prompt line specifically, I think that disabling them altogether is a better option that will reduce confusion esp. when copy-pasting the commands. Other areas will probably require more thought.

vlad-shatskyi commented 8 years ago

You've made me change my mind. Will remove them.