search

railwayapp / blog

79 stars 29 forks source link

Support nested callouts #48

Closed JakeCooper closed 6 months ago

JakeCooper commented 6 months ago

This PR (jankily) supports nested callouts

I tried to upgrade the API but found out they pulled the types from the original package. Spent 20 minutes trying to get types on the new version of the client to work and then just used an "any" instead

railway-app[bot] commented 6 months ago

🚅 Previously deployed to Railway in the 🚉 Railway Station project. Environment has been deleted.

JakeCooper commented 6 months ago

For future reference it appears we could cutover to using the types in https://github.com/makenotion/notion-sdk-js/pull/319

However, it seems that even with those types, the block object doesn't have a child property? CleanShot 2024-05-23 at 20 47 57@2x

Leaving as is and merging. Can fast follow if needed.