search

railwayapp / nixpacks

App source + Nix packages + Docker = Image
https://nixpacks.com
MIT License
2.36k stars 226 forks source link

Make Gradle 8 the default version #1021

Closed marcospereira closed 6 months ago

marcospereira commented 7 months ago

What?

This PR makes Gradle 8 the default version. The first release for Gradle 8 was made on Feb 13, 2023, so it should be safe to make it default (coming from version 7).

aleksrutins commented 7 months ago

I think this PR duplicates stuff already in #1018 exactly, though - please correct me if I'm wrong.

marcospereira commented 7 months ago

@aleksrutins, somewhat.

But I think it is better to have these changes in different pull requests, though. As far as I know, supporting Java 21 does not require making Gradle 8 the default.

aleksrutins commented 7 months ago

Just supporting Java 21 doesn't necessarily; but, since it's the new LTS version, #1018 makes it the default, which does require changing the default Gradle to 8.

marcospereira commented 7 months ago

Java 21 doesn't necessarily; but, since it's the new LTS version, #1018 makes it the default

Oh, I missed that it was making Java 21 the default. I don't have a problem with that, although I would make it an opt-in first and make it the default later.

Also, if it changes the Java default to 21, it should be more specific about Gradle versions. Running Gradle on Java 21 is supported only in version >=8.5, but test there run against Gradle 8.2:

https://github.com/railwayapp/nixpacks/blob/61f497b7a25de3fc9da20e695569d19510ebce9f/examples/java-gradle-8/gradle/wrapper/gradle-wrapper.properties#L3

https://github.com/railwayapp/nixpacks/blob/61f497b7a25de3fc9da20e695569d19510ebce9f/examples/java-gradle-8-kotlin/gradle/wrapper/gradle-wrapper.properties#L3

github-actions[bot] commented 7 months ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

marcospereira commented 7 months ago

This is not blocked by #1020, but it would be nice to get that done first.

github-actions[bot] commented 6 months ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actions[bot] commented 6 months ago

This pull request was closed for lack of activity. Feel free to reopen later.

aleksrutins commented 6 months ago

not stale

marcospereira commented 6 months ago

@coffee-cup @aleksrutins, reviving this. :-)

This is good to go (I've solved a few linting/formatting issues unrelated to my original changes).