search

railwayapp / nixpacks

App source + Nix packages + Docker = Image
https://nixpacks.com
MIT License
2.32k stars 220 forks source link

feat: dump build command when --out is specified #1115

Open iloveitaly opened 3 weeks ago

iloveitaly commented 3 weeks ago

Follow-up from https://github.com/railwayapp/nixpacks/pull/1066

Is the use case mainly for debugging what Nixpacks is doing? I wonder if we could instead of a verbose mode where the docker command is output in the logs. Would that solve the problem?

Yes. Primarily for debugging.

Without this, it's hard to actually recreate what nixpacks is doing when building a dockerfile to iterate on the Dockerfile config locally.

Outputting the build command would be fine, but it seems better to me to persist the necessary commands to build the entire docker container exactly like nixpacks does when --dump is used.

iloveitaly commented 3 weeks ago

This also fixes a listing error that I believe exists in master 70e0a6ab41f62438191548ec1425cf8046060bef

github-actions[bot] commented 2 weeks ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

iloveitaly commented 2 weeks ago

Friendly reminder on this pull request! Feel free to let me know if there are any updates needed here.

github-actions[bot] commented 4 days ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

iloveitaly commented 1 day ago

Friendly reminder about this pull request! Please let me know if there is anything else that needs to be addressed.