search

railwayapp / nixpacks

App source + Nix packages + Docker = Image
https://nixpacks.com
MIT License
2.32k stars 220 forks source link

[WIP] Support for building in a specific Docker network #1118

Closed Thijmen closed 3 weeks ago

Thijmen commented 3 weeks ago

See https://github.com/railwayapp/nixpacks/issues/1057

This is my attempt, and still a work in progress (untill [WIP] is out of the PR name 😄 ). Please note that this is my first time writing Rust, so my code might not be using the best practices or stuff the maintainers of nixpacks would like to see.

I am very much open to feedback thoughout this process.

Thijmen commented 3 weeks ago

A question; how can I let this PR run the tests? I added some tests, hope I did not mess up the GH Actions YML; I am not the best with GH Actions.

Thijmen commented 3 weeks ago

I'm ditching this and am going to create a PR for adding --add-host to the Docker build