Closed CoderJoshDK closed 2 months ago
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days
Hey can you resolve conflicts and fix lint?
The lint error was because the clippy
command provided in the CONTRIBUTING.md
file was not the same as the command used by the CI. So, I also updated that command (in the contributing file.)
Sorry, missed that there was a conflict too. Should be all fixed now.
The
docker_run_tests
, tests, do not properly cleanup after itself. The changes made are as follows:-v
todocker rm
docker rmi
after containers all stopped and removedstop_and_remove_container_by_image
on all images, not just ones that hangget_container_ids_from_image
never awaits anything. It was not a real async function. As such, the async syntax was removed for itSome standing issues with the tests:
test_docker_host
will set a broken host on all tests that follow it. Not an issue if tests are done in isolation. But it becomes an issue if all tests are run together. (at least on my machine)