railwayapp / nixpacks

App source + Nix packages + Docker = Image
https://nixpacks.com
MIT License
2.54k stars 238 forks source link

feat(tests): better cleanup on docker tests #1127

Closed CoderJoshDK closed 2 months ago

CoderJoshDK commented 3 months ago

The docker_run_tests, tests, do not properly cleanup after itself. The changes made are as follows:

Some standing issues with the tests:

github-actions[bot] commented 2 months ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

JakeCooper commented 2 months ago

Hey can you resolve conflicts and fix lint?

CoderJoshDK commented 2 months ago

The lint error was because the clippy command provided in the CONTRIBUTING.md file was not the same as the command used by the CI. So, I also updated that command (in the contributing file.)

CoderJoshDK commented 2 months ago

Sorry, missed that there was a conflict too. Should be all fixed now.