railwayapp / nixpacks

App source + Nix packages + Docker = Image
https://nixpacks.com
MIT License
2.47k stars 232 forks source link

Support gradle 8 #942

Closed heojay closed 1 year ago

heojay commented 1 year ago

Resolves #921

Screen Shot 2023-08-07 at 15 46 00
coffee-cup commented 1 year ago

I suspect that this doesn't work correctly because we are on an older version of the Nixpacks archive. Can you please add a test to check if Gradle 8 is correctly used.

heojay commented 1 year ago

@coffee-cup Ok, I will add the test using gradle 8.

heojay commented 1 year ago

I don't know much about both zig and gyro, but the reason why the zig-gyro test fails in CI seems to be due to the inaccessibility of the astrolabe.pm specified in the file below.

https://github.com/railwayapp/nixpacks/blob/b0b8cd4874ca75ab1f512d92e5f4503f21a0c611/examples/zig-gyro/gyro.lock#L1

Miloas commented 1 year ago

I guess thats because zig 0.11 break the gyro. (gyro is archived, so I think the author wont fix this) Maybe we can pin zig version to 0.10.1 for gyro project and also add support for zig official package manager

coffee-cup commented 1 year ago

The version of gradle that is actually being installed is Gradle 7 since the Nix archive version is not up to date.

image

If possible, can you do something like this https://github.com/railwayapp/nixpacks/blob/main/src/providers/elixir.rs#L14 to manually set the archive version to one with Gradle 8.

heojay commented 1 year ago

@coffee-cup Thanks for your comment, I will take a look.

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

heojay commented 1 year ago

@coffee-cup Sorry, but could you please check this PR? Thank you.