railwaycat / homebrew-emacsmacport

Emacs mac port formulae for the Homebrew package manager
BSD 2-Clause "Simplified" License
1.68k stars 126 forks source link

Remove appcast #342

Closed mpolden closed 1 year ago

mpolden commented 1 year ago

The appcast stanza has been deprecated in a recent version of Homebrew. This causes a warning to be printed for every Homebrew command:

Warning: Calling the `appcast` stanza is deprecated! Use the `livecheck` stanza instead.
Please report this issue to the railwaycat/emacsmacport tap (not Homebrew/brew or Homebrew/homebrew-core), or even better, submit a PR to fix it:
  /usr/local/Homebrew/Library/Taps/railwaycat/homebrew-emacsmacport/Casks/emacs-mac.rb:23

However, I don't think there is any point in having appcast or livecheck for this cask since it's a custom tap where the cask definition and release are published together.

mpolden commented 1 year ago

Any thoughts on this, @railwaycat? My terminal is overflowing with warnings. 😅

railwaycat commented 1 year ago

Sorry for the inconvenience! I am outside now just with my phone. I will merge the PR first.

ViktorHaag commented 1 year ago

Hey folks, we forgot about the spacemacs-icon cask recipe in this change, so I added a new PR (345) to catch it up with the base cask recipe changes.