search

raimon49 / pip-licenses

Dump the license list of packages installed with pip.
MIT License
307 stars 43 forks source link

Ignore spaces around fail-on and allow-only parameters #109

Closed Akarys42 closed 3 years ago

Akarys42 commented 3 years ago

In its current format, this tool will always fail if there are spaces around the semicolons in the fail-on or allow-only parameters, such as License 1; License 2. This is due to the second license to be parsed as " License 2" with a space at the beginning, not matching "License 2".

This can be problematic in YAML-based CI setups for example, where you wouldn't be able to add line breaks inside the command without adding additional spaces, which is the problem I am currently facing.

This commit solves that by passing arguments through str.strip.

codecov[bot] commented 3 years ago

Codecov Report

Merging #109 (6e1e947) into master (5121c4c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files           1        1           
  Lines         390      390           
=======================================
  Hits          386      386           
  Misses          4        4
Impacted Files Coverage Δ
piplicenses.py 98.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5121c4c...6e1e947. Read the comment docs.

raimon49 commented 3 years ago

@Akarys42 I had overlooked this issue.

Your changes look good. I will merge this change and release the next version 3.5.2.

Thanks for your report and Pull Request.

Akarys42 commented 3 years ago

Thank you!