raimon49 / pip-licenses

Dump the license list of packages installed with pip.

MIT License

307 stars 43 forks source link

feat: depend on importlib_metadata rather than pip #129

Closed b-kamphorst closed 1 year ago

b-kamphorst commented 1 year ago

Especially, rather than functions that are internal to pip.

Solves https://github.com/raimon49/pip-licenses/issues/128.

b-kamphorst commented 1 year ago

@raimon49 I look forward to your thoughts! If you approve, please let me know what version you'd like to assign so I can update that accordingly.

b-kamphorst commented 1 year ago

Note that, for python 3.7, the proposed change implies that importlib_metadata (Apache license) is installed as a pip-licenses dependency. I think this dependency should be added to SYSTEM_PACKAGES just like PTable/prettytable ?

raimon49 commented 1 year ago

@b-kamphorst Thanks, I have installed Python 3.11.0 in my environment as well and confirmed the error you reported.

codecov[bot] commented 1 year ago

Codecov Report

Merging #129 (129cadb) into master (12d5d5f) will increase coverage by 0.75%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
+ Coverage   98.97%   99.73%   +0.75%     
==========================================
  Files           1        1              
  Lines         391      376      -15     
==========================================
- Hits          387      375      -12     
+ Misses          4        1       -3

Impacted Files	Coverage Δ
piplicenses.py	`99.73% <100.00%> (+0.75%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

raimon49 commented 1 year ago

@b-kamphorst Thanks for the good discussion and great contribution!

I have created a branch for the v4.0.0 release (same commit as the master branch) for work on the following tasks. Can you please change the base branch of this Pull Request to release-4.0.0 ?

Merge this Pull Request into the release-4.0.0 and then move on to the next task.

Migrate dependency library from PTable to prettytable
Bump up version to 4.0.0rc1
- Upload the release candidate version to PyPI because it involves breaking changes
- We will officially release it after getting feedback from users
Update README documentation and more

b-kamphorst commented 1 year ago

@b-kamphorst Thanks for the good discussion and great contribution!

My pleasure!

I have created a branch for the v4.0.0 release (same commit as the master branch) for work on the following tasks. Can you please change the base branch of this Pull Request to release-4.0.0 ?

Done. With that I think my work here is done? Also, #116 can be closed.

raimon49 commented 1 year ago

We will now work on the 4.0.0 release at PR #131 .

If there is anything that you are interested in, I would be happy to get a PR from you on release-4.0 branch.