raimon49 / pip-licenses

Dump the license list of packages installed with pip.
MIT License
314 stars 45 forks source link

fix: populate tables and test ReST table #74

Closed pohlt closed 4 years ago

pohlt commented 4 years ago

ReST, markdown, and confluence tables are tested with the actual installed packages. Furthermore, the ReST table is being parsed by docutils for errors.

pohlt commented 4 years ago

This PR is a preparation for issue #73, because currently the ReST tables are tested without actual packages and the resulting ReST string is not being parsed by docutils.

raimon49 commented 4 years ago

Thank you for P-R.

I have confirmed running the test including evaluating the rest parser.

We maintain the code style according to PEP 8.

Could you fix the following?

============================================================= FAILURES =============================================================
________________________________________________________ pycodestyle-check _________________________________________________________
/git/pip-licenses/test_piplicenses.py:54:80: E501 line too long (95 > 79 characters)
/git/pip-licenses/test_piplicenses.py:59:80: E501 line too long (93 > 79 characters)
pohlt commented 4 years ago

Sure. Done.

codecov[bot] commented 4 years ago

Codecov Report

Merging #74 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files           1        1           
  Lines         323      323           
=======================================
  Hits          318      318           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76b4971...6566a41. Read the comment docs.

raimon49 commented 4 years ago

@pohlt OK, thank you for your contribution!!