raimon49 / pip-licenses

Dump the license list of packages installed with pip.
MIT License
314 stars 45 forks source link

Release 3.0.0 #77

Closed raimon49 closed 4 years ago

raimon49 commented 4 years ago

Release version of v-3.0.0

Key changes and goals

Task list

codecov[bot] commented 4 years ago

Codecov Report

Merging #77 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files           1        1           
  Lines         338      338           
=======================================
  Hits          333      333           
  Misses          5        5           
Impacted Files Coverage Δ
piplicenses.py 98.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5cf53c...7908092. Read the comment docs.

johnthagen commented 4 years ago

https://github.com/raimon49/pip-licenses/blob/59a420eb7499ece5ebf6d88caaa431a2f1cdb302/piplicenses.py#L528

You could use an enum here given Python 2.7 is no longer supported.

johnthagen commented 4 years ago

Another possible idea is to use type hints to make the functions in this piplicenses.py a little easier to understand. See PEP 484.

This also has the added benefits that editors such as PyCharm and VS Code will provide more auto-complete/inspection when contributors are working on the code base.

raimon49 commented 4 years ago

The packages released by TestPyPI seem to be working well. https://test.pypi.org/project/pip-licenses/3.0.0/

raimon49 commented 4 years ago

The release to PyPI is complete. https://pypi.org/project/pip-licenses/3.0.0/

johnthagen commented 4 years ago

We've been using 3.0.0 and it's been working great. The new default --from=mixed has allowed us to simplify a bunch of scripts that run pip-licenses. Thanks!