Open cdce8p opened 3 years ago
Note: I have a security alert from dependabot and have updated the dev-requirements.txt
. So, dev-4.0.0
has been rebased to commit 7dba43c2e8799016d975004a1f689234ac4407a0 and force pushed.
Note: I have a security alert from dependabot and have updated the
dev-requirements.txt
. So,dev-4.0.0
has been rebased to commit 7dba43c and force pushed.
Thanks for letting me know!
I was notified of an insecure version of the dependency from dependabot and the dev-4.0
branch was rebased to 3c9aab1dda81edfb7232e726cdda8ba892e240e1.
I'd love if #71 were considered for 4.0 somehow. As someone who relies on pip-licenses
to help properly display license information of third party packages, missing some of their license files has always felt a little non-ideal. I'd created a proof-of-concept in #78 on what this could look like.
I'd love if #71 were considered for 4.0 somehow. As someone who relies on
pip-licenses
to help properly display license information of third party packages, missing some of their license files has always felt a little non-ideal. I'd created a proof-of-concept in #78 on what this could look like.
@johnthagen I unfortunately didn't had much time the last couple of weeks so the progress came to a bit of a hold. Hope to continue with it soon. As for your suggestion, I've added it to the list. It does seem reasonable. Have to see how to best implement it.
Have to see how to best implement it.
Sounds great. Feel free to check out #78 where I had a working prototype. The challenge was consistency with output formats that had difficulty handling a list of license files.
I personally only need --format=plain-vertical
as I feel its one of the few that works well with license file contents (which can have all kinds of characters that mess up other table-based formats anyway).
dev-4.0
branch has been rebased with v-3.3.1 tag as the branch source.
@cdce8p Can I leave it to you to port the code that corresponds to #94?
@raimon49 Just opened #96
Today, I added the following commit to my master
branch.
dev-4.0
branch has also been rebased from the latest master branch. The test cases have priority over the code in the dev-4.0
branch.
Today, I added the following commit to my
master
branch.
Updated development dependencies to resolve security alerts.
Fixing broken test cases.
dev-4.0
branch has also been rebased from the latest master branch. The test cases have priority over the code in thedev-4.0
branch.
Thanks for the heads up. I unfortunately don't have much that free time to work on it at the moment, although I do plan to come back to it at some point.
The last few weeks I've worked on a few improvements for setuptools
that will ultimately also help us here once they are widely adopted. That includes
License
metadata field. Previously, multiline licenses would almost certainly have broken the metadata file.license_files
option now supports glob patterns, overwrites any manifest settings and has reasonable defaults if not specified. That should help many projects with including their license files in the source distribution. wheel
does include something similar for the build distribution.License-File
metadata field. That should help finding the relevant licensing files in a package. https://github.com/pypa/setuptools/pull/2645@cdce8p As more people move to alternatives to setuptools
such as Poetry, will these enhancements also need to be added to those tools as well?
@cdce8p As more people move to alternatives to
setuptools
such as Poetry, will these enhancements also need to be added to those tools as well?
I believe so, unfortunately. Especially the License-File
metadata field probably depends on PEP 639 before it really takes off, but there hasn't been much movement on it lately. https://discuss.python.org/t/pep-639-improving-license-clarity-with-better-package-metadata/2154
@johnthagen If you're familiar with Poetry, maybe you want to open an issue there for them to add it. (Since I haven't used it, I don't know what features regarding license files they do support.)
@cdce8p Thank you for giving us such great news! Your contribution to setuptools is excellent.
pip-licenses 4.0.0 has been released, including some of the plans discussed in this issue. https://pypi.org/project/pip-licenses/4.0.0/
For this reason, I have changed the issue title.
This issue should track the progress to the next major release and provide a place to have discussions about features.
Features
Ideas
setup.cfg
importlib.metadata
(Python 3.8 and up). Replacesget_installed_distributions
The ideas are subject to change and might not all get implemented. I'll move ideas to the feature column once a PR is created.
Discussions
Add flake8, pylint Those checks are relatively easy to add and might at some code quality improvements. At least the provide useful guides when used with IDEs (eg. VS Code)
Require Python 3.7 I'm not completely sure about this one. But some good arguments in favor