Closed rain-1 closed 6 years ago
https://github.com/antirez/linenoise/pull/87
The majority of this PR is rejected, there is no need to make the file polymorphically C and C++. Especially since https://github.com/yhirose/cpp-linenoise exists.
Just ensure that we have this memory leak fix https://github.com/antirez/linenoise/pull/87/commits/ff7e3990cf4f14ab3d077e6b6448c4cdce48739a then close this issue.
we don't have this memory leak.
rain-1
commented
6 years ago
https://github.com/antirez/linenoise/pull/87
The majority of this PR is rejected, there is no need to make the file polymorphically C and C++. Especially since https://github.com/yhirose/cpp-linenoise exists.
Just ensure that we have this memory leak fix https://github.com/antirez/linenoise/pull/87/commits/ff7e3990cf4f14ab3d077e6b6448c4cdce48739a then close this issue.