rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

feat: approvals Cmd+K shortcuts #1637

Closed magiziz closed 3 months ago

magiziz commented 3 months ago

Fixes BX-1573 Figma link (if any):

What changed (plus any additional context for devs)

  1. Added Approvals shortcut to CmdK
  2. Added Revoke an Approval shortcut to CmdK that links to the same screen as Approvals shortcut

Screen recordings / screenshots

approvals_shortcut

What to test

Make sure that both Approvals and Revoke an Approval shortcuts redirect to the approvals settings screen

linear[bot] commented 3 months ago

BX-1573 Approvals shortcuts in Cmd K

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-7f3058b304b0b142e70c53fab9c5573671b26d7b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-7f3058b304b0b142e70c53fab9c5573671b26d7b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-7f3058b304b0b142e70c53fab9c5573671b26d7b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-7f3058b304b0b142e70c53fab9c5573671b26d7b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-7f3058b304b0b142e70c53fab9c5573671b26d7b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: rainbowbx-d24d45435a348b963c6a4a0c1647474398f3d040

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-6315ca6e68021879337ab29b92412c4b3b137c17

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-6315ca6e68021879337ab29b92412c4b3b137c17

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-6315ca6e68021879337ab29b92412c4b3b137c17

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-e8bcaeeb8ab81a4b463a2899d7f36f803ba0ea4b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-e8bcaeeb8ab81a4b463a2899d7f36f803ba0ea4b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-e8bcaeeb8ab81a4b463a2899d7f36f803ba0ea4b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-88b815497e63f156e0ecd256a287b1ee074a786a screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-88b815497e63f156e0ecd256a287b1ee074a786a screenshots

DanielSinclair commented 3 months ago

Tweaked the unit test timeouts here. Oddly seeing Swap tests failed now too 🤔

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: rainbowbx-88b815497e63f156e0ecd256a287b1ee074a786a

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: rainbowbx-481fb9b095154a7cfd26b5cf9d881fa981675186