search

rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
169 stars 40 forks source link

fix: disable activity details shortcuts without dropdown #1640

Closed derHowie closed 4 months ago

derHowie commented 4 months ago

Fixes BX-1565

What changed (plus any additional context for devs)

From ticket: "Goal:

Only register Token Details shortcuts when the context menu is visibile

Allow a user to select text and copy"

The shortcuts associated with the more options menu in token details now are only active when the dropdown is visible.

What to test

Make sure that token details does not intercept the 'C' key when the more options dropdown is hidden.

linear[bot] commented 4 months ago

BX-1565 Token Details shortcut registration blocks `Cmd+C` copy

github-actions[bot] commented 4 months ago

Here's the packed extension for this build: rainbowbx-18f815c27305ef0946473050bf3fff442d01252d

github-actions[bot] commented 4 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-5ffb3fb69ab60b5bf367b618c60e9ea13a087907