rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
169 stars 40 forks source link

perceived finality #1649

Closed derHowie closed 3 months ago

derHowie commented 3 months ago

Fixes BX-1580 tech spec: https://www.notion.so/rainbowdotme/Perceived-Finality-doc-12d4f7e088e74654ab433d5c661de220

What changed (plus any additional context for devs)

When a pending transaction is detected as confirmed, we are flagging the affected assets' addresses and refetching updated user assets balances from BE.

Additionally, pending transactions were being almost immediately removed from the UI due to an existing bug. The pending transactions should now remain for the full duration.

What to test

Ensure the token params sent to BE reflect the correct addresses when the app attempts to update user asset balances.

Suggestions from Jin:

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-380c751eb2d98adc6eca4a4e1b480368119156ca screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-d7086c18af9b2b7c4d4d05782364ae07e029f47b screenshots

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-1a0c44f37937231786aae2dedf0e72e110e0b855 screenshots

linear[bot] commented 3 months ago

BX-1580 Balance change reflections after transaction submission