search

rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
170 stars 40 forks source link

reduce animation dropdown on bridge entry point (swaps) #1655

Closed magiziz closed 3 months ago

magiziz commented 3 months ago

Fixes BX-1083 Figma link (if any):

What changed (plus any additional context for devs)

Reduce showing receive dropdown on bridge entry point from token details page or home page

Screen recordings / screenshots

https://github.com/user-attachments/assets/04ec46cf-f7ec-49cf-891c-7ee8ae9b7de7

What to test

Home page:

  1. Right click on token
  2. Click bridge menu
  3. Make sure you don't see the receive dropdown open on bridge page

Token details page:

  1. Click bridge button
  2. You shouldn't see the receive dropdown open on bridge page (same behaviour from home page)
linear[bot] commented 3 months ago

BX-1083 Reduce presentation animation waterfall on Bridge entry-point

github-actions[bot] commented 3 months ago

Here's the packed extension for this build: rainbowbx-351bdd3ea0fad537ef64fd53d5d11ea271221497

greg-schrammel commented 3 months ago

wydt of removing the animation in this case instead of keeping it closed? like route and the buy dropdown is already open not animated

magiziz commented 3 months ago

@greg-schrammel Yeah right. They're not animated on mount basically.

greg-schrammel commented 3 months ago

@greg-schrammel Yeah right. They're not animated on mount basically.

but it routes to the page with it closed? shouldn't it be open just not show the opening animation

magiziz commented 3 months ago

@greg-schrammel Ah yeah good point. I'll disable the animation instead.

DanielSinclair commented 3 months ago

@magiziz Want to pick this one back up?

DanielSinclair commented 3 months ago

@magiziz Available to push this to the finish line?