search

rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

limit percentage reduction in token details #1660

Closed magiziz closed 2 months ago

magiziz commented 3 months ago

Fixes BX-1564 Figma link (if any):

What changed (plus any additional context for devs)

Capped the percentage on the token details page to not decrease more than -100%.

Screen recordings / screenshots

Before:

BX-1564 (after)

After:

BX-1564 (before)

What to test

Select a token that experienced a significant decrease over time such as $DEGEN and make sure that when hovering over the graph at its lowest point the decrease does not exceed -100%.

linear[bot] commented 3 months ago

BX-1564 Incorrect chart percentage change

magiziz commented 3 months ago

@estebanmino Yeah, but seems like price from coinmarketcap and coingecko are showing the same results.

magiziz commented 3 months ago

We've found out that that there is a small bug in the charts where it shows Infinity. I've messaged the backend team to let them know.

DanielSinclair commented 3 months ago

Moved to draft while we workout the Backend change

DanielSinclair commented 2 months ago

Closing for now because I assume Backend will handle this fix