search

rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

update swap sdk v23 #1662

Closed greg-schrammel closed 3 months ago

greg-schrammel commented 3 months ago

Fixes BX-1585 Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@rainbow-me/swaps@0.23.0 environment, eval, network 0 786 kB brunobar79

🚮 Removed packages: npm/@rainbow-me/swaps@0.21.0

View full report↗︎

linear[bot] commented 3 months ago

BX-1585 Upgrade to latest Swap SDK and use information from new (buy|sell|fee)TokenAsset fields to reduce external data dependencies

DanielSinclair commented 3 months ago

@BrodyHughes This might need a full Swap regression. I think this affects quotes for different currencies, so you might want to try it out with different currency settings

DanielSinclair commented 3 months ago

@greg-schrammel Noticed the above error in the console as well

greg-schrammel commented 3 months ago

Tested swaps on:

  • mainnet
  • L2
  • L2 with non-eth gas token
  • mainnet custom RPC
  • L2 custom RPC
  • L2 with non-eth gas token and custom RPC
  • 3 separate currency types (USD, ETH, and Yen)

All looks good! Only concern is getting some odd console error on Matic swaps but the swap still succeeded.

Screenshot 2024-08-14 at 1 19 42 PM

this logged error is useQuery complaining we are not using it in the intended way, was happening before, not related to this pr

gonna think of a way to change that but in later pr

DanielSinclair commented 3 months ago

Temporarily removing the Firefox checks here; Brody is refactoring that in a separate PR. This should get automatically merged once Bruno amends one of the repo settings later today.