search

rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

Re-adding optional chaining for sellAsset and buyAsset on quote response #1673

Closed jinchung closed 2 months ago

jinchung commented 2 months ago

Fixes BX-1610

Related to: https://github.com/rainbow-me/rainbow/pull/6022

What changed (plus any additional context for devs)

Re-added optional chaining on Quote object as the WETH/ETH unwrap/wrap path has different response type than normal swaps.

Screen recordings / screenshots

Did not take screen recordings - someone please verify.

What to test

Test ETH -> WETH and flip (WETH -> ETH)

linear[bot] commented 2 months ago

BX-1610 Trying to swap WETH causes "something went wrong" error