search

rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

Fix pk back nav #1688

Closed BrodyHughes closed 2 months ago

BrodyHughes commented 2 months ago

Fixes: BX-1619:

previous behavior:

  1. navigate to wallet details
  2. more menu
  3. View PK
  4. 'i've saved these words'
  5. hit back nav
  6. goes back to the pkey page instead of settings (incorrectly exposing PK) (see ticket for repro video

FIxed behavior: 1-5 above

  1. goes back to settings

POW:

We had existing logic for navigating back to settings from this sort of state, just needed to pass it into the state nav

linear[bot] commented 2 months ago

BX-1619 Private key or seed phrase exposed after back navigation on bx