rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

fix: prevent underflow error when parsing native asset fee and price #1690

Closed derHowie closed 2 months ago

derHowie commented 2 months ago

Fixes BX-1629

What changed (plus any additional context for devs)

Changed how we parse native asset fee and price to prevent underflow errors thrown by bignumber.

Error: consolidatedTransactionsQueryFunction:  {
  "message": {
    "reason": "fractional component exceeds decimals",
    "code": "NUMERIC_FAULT",
    "fault": "underflow",
    "operation": "parseFixed"
  }
}

Screen recordings / screenshots

Screenshot 2024-09-06 at 7 28 06 AM

What to test

Grunt.eth has transactions that were blowing up tx history. Reference the slack thread if you want to find more example addresses to test.

linear[bot] commented 2 months ago

BX-1629 Wallet balance and transaction history not loading