rainbow-me / browser-extension

An Ethereum wallet built for speed 🌈
https://rainbow.me/
GNU General Public License v3.0
168 stars 40 forks source link

Fix BX-1641 & BX-1642 #1703

Closed derHowie closed 1 month ago

derHowie commented 1 month ago

What changed (plus any additional context for devs)

We were not properly clearing swap data when a user cleared the input or manually typed '0' into the swap inputs.

Screen recordings / screenshots

PoW: https://www.loom.com/share/5415e6ba392f474489728d7a1a50cbf1

What to test

Reference the bugs detailed in the two attached tickets, but generally play the swap inputs and ensure that unnecessary market warnings are not displayed when clearing swap input data and that we don't see any wacky values displayed in the native currency display fields when swap input data is cleared from either input.

linear[bot] commented 1 month ago

BX-1641 Token overflow issue with deleting input values

BX-1642 Small Market quote warning not dismissed