rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket
https://rainbow.me
GNU General Public License v3.0
3.82k stars 590 forks source link

disabled typing in output amount when cross-chain swap #5767

Closed walmat closed 1 month ago

walmat commented 1 month ago

Fixes RNBW-4724

What changed (plus any additional context for devs)

Added functionality to disable typing in output amount while attempting to swap cross-chain.

Screen recordings / screenshots

What to test

linear[bot] commented 1 month ago

RNBW-4724 When bridging and updating the output value, the input value does not update

walmat commented 1 month ago

curious if this is related. when i swap blast token -> blast token, the chain badge doesn't show up on the output token. however, if i swap non-blast L2 token -> same non-blast L2 token, the chain badge does show up on the output token

Simulator Screenshot - iPhone 15 Pro - 2024-05-24 at 08 35 24

Simulator Screenshot - iPhone 15 Pro - 2024-05-24 at 08 34 13

fixed in: https://github.com/rainbow-me/rainbow/pull/5772