search

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket
https://rainbow.me
GNU General Public License v3.0
3.82k stars 590 forks source link

swap button states #5785

Closed greg-schrammel closed 2 weeks ago

greg-schrammel commented 1 month ago

Fixes APP-1486

What changed (plus any additional context for devs)

Screen recordings / screenshots

https://github.com/rainbow-me/rainbow/assets/6232729/84631374-a2d4-47f0-9b79-aa0c1df53b40

What to test

jinchung commented 3 weeks ago

RESOLVED

https://github.com/rainbow-me/rainbow/assets/1285228/3c914426-d61d-42ef-876b-07aa127085aa

Couple things I notice here:

  1. going from the normal Swap button -> default ETH is selected -> output native value is $NaN for a little bit (might not be related to your changes)
  2. Once I select an output currency, the button is "Insufficient Funds" - I then delete a digit and then it resolves but when I add it back in (even though I have sufficient funds), it goes back to insufficient funds
  3. also notice that the button goes from "greyed out Fetching..." to "not greyed out Fetching..." to "Review" very quickly (if you slow it down) which makes it have this jittery feel
jinchung commented 3 weeks ago

STILL HAPPENING

https://github.com/rainbow-me/rainbow/assets/1285228/367219c9-933e-449a-b286-a8a3778bdc6d

When tapping the Review button, I'm not getting it to open up the review sheet.

jinchung commented 3 weeks ago

https://github.com/rainbow-me/rainbow/assets/1285228/b928fa6d-4926-4a65-b9ab-89e492b1fbf2

I'm seeing a consistent flashing when going back and forth between max and less than max for the network's native token:

  1. In the video, I move from default to max: see fetching -> flash of Review -> insufficient funds
  2. when I go back down from max: see fetching -> flash of Insufficient Funds -> Review