fix getProviderForNetwork type - Githubissues

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket

https://rainbow.me

GNU General Public License v3.0

3.82k stars 590 forks source link

fix getProviderForNetwork type #5843

Closed brunobar79 closed 2 weeks ago

brunobar79 commented 2 weeks ago

Fixes APP-####

What changed (plus any additional context for devs)

Fixes 2 issues:

We were incorrectly using getCachedProviderForNetwork in a few places which was causing bugs like https://rainbowhaus.slack.com/archives/C06NDH4FQTB/p1718232669117889
getProviderForNetwork return type was wrong, it's not a promise so we have to remove the await everywhere where it is used.

Screen recordings / screenshots

What to test