Closed greg-schrammel closed 3 months ago
The flashbots part seems to be working fine but there's other issues:
1 - Flashbots off - select any speed other than custom - go to review panel - tap the gas settings icon - you'll see that the current speed values get overwritten with old saved custom values instead of the correct ones. Also notice how the Max transaction fee becomes "$0.00"
I believe custom gas settings should be cleared once you switch to a predefined speed or at least the custom gas settings should be overriden with the current selected speed.
https://github.com/rainbow-me/rainbow/assets/1247834/ed206895-758e-458e-ac22-5f1cd1c60597
2 - We need to clear custom gas settings from the store right after submitting the rap since it's a one time usage kind of feature, otherwise future transactions will use potentially outdated values
@greg-schrammel - These 2 issues are kind of out of the scope of the flashbots min tip work so I'm ok with merging this and fixing these separately if you prefer but we need to create a new ticket and mark it "in progress'
Fixes APP-####
What changed (plus any additional context for devs)
when flashbots is enabled uses 6 as the priority fee, or a min of 6 when setting custom gas settings
https://github.com/rainbow-me/rainbow/assets/6232729/e6f1279b-7708-49fc-bc3f-008d1ab5e76f
Screen recordings / screenshots
What to test