What changed (plus any additional context for devs)
Fixes the missing swap button press animations and haptic feedback
Adjusts the review button state logic to allow entering the review sheet when isFetching.value === true, except for the first quote fetch
When the review sheet is open, if a new quote is being fetched, the tapToSwap button now becomes disabled until the new quote is applied
Moves the tapToSwap button state condition further down so that if assets are flipped while in the review sheet, or gas conditions change, the tapToSwap button can become disabled
Also:
Switches the initial inputMethod to inputAmount if an input asset is selected on mount, which fixes a bug that was causing the input values to change when the swap screen was first opened (very likely due to the animated reaction that manages the input values hitting the inputMethod === 'slider' logic path)
Fixes APP-1614
What changed (plus any additional context for devs)
isFetching.value === true
, except for the first quote fetchtapToSwap
button now becomes disabled until the new quote is appliedtapToSwap
button state condition further down so that if assets are flipped while in the review sheet, or gas conditions change, thetapToSwap
button can become disabledAlso:
inputMethod
toinputAmount
if an input asset is selected on mount, which fixes a bug that was causing the input values to change when the swap screen was first opened (very likely due to the animated reaction that manages the input values hitting theinputMethod === 'slider'
logic path)Screen recordings / screenshots
https://github.com/rainbow-me/rainbow/assets/7061887/833720a3-954e-4193-9cc0-8fda1c457da2
What to test