search

rainbow-me / rainbow

🌈‒ the Ethereum wallet that lives in your pocket
https://rainbow.me
GNU General Public License v3.0
3.82k stars 590 forks source link

Remove input value typeof checks #5886

Closed jinchung closed 1 week ago

jinchung commented 1 week ago

What changed (plus any additional context for devs)

  1. Removed all places where we relied on typeof for the input value amounts. This was making things brittle / difficult to maintain / easy to get into scenarios you did not intend.
  2. Updated the initial values for native currency to not need to worry about formatting since we have formattedNativeInput to handle that
  3. Removed the conditional for the default input method to have it back to be slider based

Screen recordings / screenshots

https://github.com/rainbow-me/rainbow/assets/1285228/82b3f2df-9091-4bc2-a224-abeefa44cabc