Closed jinchung closed 2 days ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/@rainbow-me/swaps@0.22.0 | environment, eval, network | +11 |
3.4 MB | brunobar79 |
🚮 Removed packages: npm/@rainbow-me/swaps@0.21.0
Fixes APP-1620
What changed (plus any additional context for devs)
Issues solved:
This PR will require some follow up after launch. We have a few updates that we want to do from the backend, so for now, the minimum received value is hooked up correctly (value after fees and slippage) but the maximum sold amount currently matches the input amount for output-based trades (the most pessimistic/conservative estimate we have.) We'll update this in a later release.
What to test
Test with a variety of input-based vs output-based trades. Input-based trades should show "Minimum Received" in the review panel with a value that is less than the output amount. Output-based trades should show "Maximum Sold" in the review panel with a value that matches in the input amount. (This will be updated later)
Screen recordings / screenshots