What changed (plus any additional context for devs)
added comments inline below!
issue: if the value of the output field is something like "123.00567", the output was displaying "123" instead of "123.00"
this is because in the valueBasedDecimalFormatter, we only specified max decimals and not min decimals, and while the max decimals would be 2, in the instance where we round down for output based values, it was rounding to 123.00 and then just displaying 123
this PR adds support for minimum and maximum decimals and will serve as a base for future improvements to our decimal formatting.
other than the stablecoin change, everything else should be a no-op.
What to test
decimal formatting should not be impacted except for stablecoins as output assets
at various stablecoin output amounts, any value that is "XXX.00" should display with the 2 decimal spots instead of just "XXX"
Screen recordings / screenshots
In the screenshot below, I "faked" an output value such as "676.00789" so I didn't have to keep messing with the input to get the output I wanted
linear[bot]
commented
3 days ago
Fixes APP-1613
What changed (plus any additional context for devs)
valueBasedDecimalFormatter, we only specified max decimals and not min decimals, and while the max decimals would be 2, in the instance where we round down for output based values, it was rounding to 123.00 and then just displaying 123What to test
Screen recordings / screenshots
In the screenshot below, I "faked" an output value such as "676.00789" so I didn't have to keep messing with the input to get the output I wanted