raps v2

[benisgold]

Fixes APP-####

What changed (plus any additional context for devs)

i recreated raps for the following reasons

• raps v1 does not support different sets of params for different actions within the same rap
• raps v1 requires params for a "swap" type action, limiting raps to those involving swaps
• code is hard to read bc of different types of raps that should be more isolated but instead are lumped together, causing messy types
• lots of type casting
• if i added the claimables rap to this, it would get much more messy bc it's pretty different from existing raps

Screen recordings / screenshots

What to test

nothing to test bc this isn't in use

[brunobar79]

Launch in simulator or device for 0d9dd0f212cb5cfba3fba3af53e687731ff5de6e

[brunobar79]

Launch in simulator or device for 40c448df21342bf9a890ee13ba0afb7edc2217a7

[brunobar79]

Launch in simulator or device for 8f92d46f3125f7d516c0ab5b4f27876d6ca85402

[benisgold]

@walmat technically it isn't needed. i initially attempted type expansion, but it got messy pretty quickly. it was also difficult to follow my own code bc of all the numerous type assertions currently in raps. i figured i would try and clean things up

also for context the claimable rap types will be somewhat more complicated than what you see now because there will be the unlock/crosschain swap actions added onto this rap as well in future PRs

[benisgold]

@walmat if you want more context about my previous comment see my recent commit. i tested out (again) trying to make raps v1 compatible with claimables, and you can see how messy it gets with types. and this is just the tip of the iceberg, it gets worse. it's a slippery slope

[walmat]

@walmat if you want more context about my previous comment see my recent commit. i tested out (again) trying to make raps v1 compatible with claimables, and you can see how messy it gets with types. and this is just the tip of the iceberg, it gets worse. it's a slippery slope

i'll take a look

[sentry-io[bot]]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ Error: [rapsV2/execute]: claimTransactionClaimableAction - error execute action _callSuper(src/logger/index) View Issue

_{Did you find this useful? React with a 👍 or 👎}